Bug 142432

Summary:

[Win] Revive WTF::WorkQueue on Windows

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, bfulgham, cmarcelo, commit-queue, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

142447, 142471

Attachments:

Description	Flags
Patch	darin: review+

Description Brent Fulgham 2015-03-06 21:48:43 PST

Revive the Windows WorkQueue implementation.

Comment 1 Brent Fulgham 2015-03-06 22:07:05 PST

Created attachment 248143 [details]
Patch

Comment 2 Anders Carlsson 2015-03-07 13:04:11 PST

Comment on attachment 248143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review

> Source/WTF/wtf/WorkQueue.h:79
> +    void registerHandle(HANDLE, std::function<void()>);
> +    void unregisterAndCloseHandle(HANDLE);

I think we can get rid of these - they were only used by IPC in WK2.

Comment 3 Brent Fulgham 2015-03-07 20:50:46 PST

Comment on attachment 248143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review

>> Source/WTF/wtf/WorkQueue.h:79
>> +    void unregisterAndCloseHandle(HANDLE);
> 
> I think we can get rid of these - they were only used by IPC in WK2.

I'll get rid of it. It's easy to retrieve if we need it.

Comment 4 Brent Fulgham 2015-03-07 20:58:18 PST

Committed r181220: <http://trac.webkit.org/changeset/181220>