Bug 142432

Summary:

[Win] Revive WTF::WorkQueue on Windows

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, bfulgham, cmarcelo, commit-queue, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	darin: review+

Brent Fulgham

Reported 2015-03-06 21:48:43 PST

Revive the Windows WorkQueue implementation.

Attachments
Patch (22.48 KB, patch) 2015-03-06 22:07 PST, Brent Fulgham	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-03-06 22:07:05 PST

Anders Carlsson

Comment 2 2015-03-07 13:04:11 PST

Comment on attachment 248143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review > Source/WTF/wtf/WorkQueue.h:79 > + void registerHandle(HANDLE, std::function<void()>); > + void unregisterAndCloseHandle(HANDLE); I think we can get rid of these - they were only used by IPC in WK2.

Brent Fulgham

Comment 3 2015-03-07 20:50:46 PST

Comment on attachment 248143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248143&action=review >> Source/WTF/wtf/WorkQueue.h:79 >> + void unregisterAndCloseHandle(HANDLE); > > I think we can get rid of these - they were only used by IPC in WK2. I'll get rid of it. It's easy to retrieve if we need it.

Brent Fulgham

Comment 4 2015-03-07 20:58:18 PST

Note You need to log in before you can comment on or make changes to this bug.