Bug 142416

Summary: Support "plus-lighter" in mix-blend mode
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Dean Jackson
Reported 2015-03-06 15:49:45 PST
Support "plus-lighter" in mix-blend mode
Attachments
Patch (1.26 MB, patch)
2015-03-06 16:02 PST, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-03-06 16:00:54 PST
<rdar://problem/19993979>
Dean Jackson
Comment 2 2015-03-06 16:02:08 PST
Created attachment 248105 [details] Patch
Sam Weinig
Comment 3 2015-03-06 16:03:55 PST
r=me
Dean Jackson
Comment 4 2015-03-06 16:09:31 PST
Committed r181191: <http://trac.webkit.org/changeset/181191>
Joseph Pecoraro
Comment 5 2015-05-22 23:12:16 PDT
Comment on attachment 248105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248105&action=review > Source/WebCore/css/CSSParser.cpp:823 > - || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker)) > + || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter)) I see "plus-darker" and "plus-lighter" are applying to "mix-blend-mode". Should they also apply to "background-blend-mode"? If not, why the distinction?
Note You need to log in before you can comment on or make changes to this bug.