| Summary: | Web Inspector: unify resizer implementations used by DataGrid and Sidebar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||
| Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brian Burg
2015-03-06 11:51:04 PST
Created attachment 248084 [details]
Patch
This patch doesn't move over the following resizer interactions: - Moving undocked inspector window by its fake titlebar - Resizing docked inspector (bottom and left dock) - Resizing the quick console/split content browser - Timeline selection range and center handles Only the first one should require significant additions to Resizer.js (In reply to comment #3) > This patch doesn't move over the following resizer interactions: > > - Moving undocked inspector window by its fake titlebar > - Resizing docked inspector (bottom and left dock) > - Resizing the quick console/split content browser > - Timeline selection range and center handles > > Only the first one should require significant additions to Resizer.js Oh, there's also a UI-less DragToAdjustController that does some drag related work for sliders in the gradient editor, and drag-to-adjust in the styles editor. The controller seems fine for adjusting numbers up/down, and probably overkill for manipulating dividers/sliders. Comment on attachment 248084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248084&action=review Looks good! > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:115 > +WebInspector.DataGrid.LeftNeighboringColumnIDSymbol = Symbol("left-neighboring-column-id"); Nit: Identifier not ID > Source/WebInspectorUI/UserInterface/Views/Resizer.js:48 > + Horizontal: "resizer-rule-orientation-horizontal", > + Vertical: "resizer-rule-orientation-vertical", Symbol! > Source/WebInspectorUI/UserInterface/Views/Sidebar.js:41 > + var resizerDelegate = this; Not sure this line is needed. It is not super helpful, like it would be for booleans. Committed r181903: <http://trac.webkit.org/changeset/181903> |