Bug 142397

Summary: ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141160    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2015-03-06 08:57:26 PST 
ReadableStreamJSSource uses JSC::Strong to keep JS objects.
It should use UnspecifiedBoolType in lieu of checking for undefined values.
Comment 1 youenn fablet 2015-03-06 09:09:00 PST 
Created attachment 248066 [details]
Patch
Comment 2 Benjamin Poulain 2015-03-08 20:39:12 PDT 
Comment on attachment 248066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248066&action=review

Oh boy, why didn't anyone review this :(

> Source/WebCore/bindings/js/ReadableStreamJSSource.h:55
> +    virtual bool isErrored() { return m_error; }

!!m_error
Comment 3 youenn fablet 2015-03-09 03:37:52 PDT 
Created attachment 248239 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-03-09 04:35:17 PDT 
The commit-queue encountered the following flaky tests while processing attachment 248239 [details]:

media/track/track-insert-after-load-crash.html bug 142484 (author: bfulgham@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2015-03-09 04:36:42 PDT 
Comment on attachment 248239 [details]
Patch for landing

Clearing flags on attachment: 248239

Committed r181264: <http://trac.webkit.org/changeset/181264>
Comment 6 WebKit Commit Bot 2015-03-09 04:36:46 PDT 
All reviewed patches have been landed.  Closing bug.