Bug 142384

Summary:

Allow composited clip-path to be updated without a layer repaint

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, krit, simon.fraser, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2015-03-05 22:18:00 PST

Allow composited clip-path to be updated without a layer repaint

Comment 1 Simon Fraser (smfr) 2015-03-05 22:25:45 PST

Created attachment 248041 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-06 10:14:35 PST

Comment on attachment 248041 [details]
Patch

Clearing flags on attachment: 248041

Committed r181164: <http://trac.webkit.org/changeset/181164>

Comment 3 WebKit Commit Bot 2015-03-06 10:14:41 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Elliott Sprehn 2016-04-27 18:41:11 PDT

Comment on attachment 248041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248041&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:938
> +    return (clipPath.type() != ClipPathOperation::Shape || clipPath.type() == ClipPathOperation::Shape) && GraphicsLayer::supportsLayerType(GraphicsLayer::Type::Shape);

You have (.type() != ::Shape || .type() == ::Shape) && ...

Did you mean to check for != to something different?