Bug 142377

Summary: [iOS] SVG fonts are garbled
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Myles C. Maxfield 2015-03-05 19:02:58 PST
[iOS] SVG fonts are garbled
Comment 1 Myles C. Maxfield 2015-03-05 19:04:45 PST
Created attachment 248029 [details]
Patch
Comment 2 Myles C. Maxfield 2015-03-05 19:06:53 PST
<rdar://problem/19616000>
Comment 3 Simon Fraser (smfr) 2015-03-05 19:24:58 PST
Comment on attachment 248029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248029&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1039
> +    append32(vector, clampTo<int32_t>(number * 0x10000));

This deserves a comment about why you do * 0x10000
Comment 4 Myles C. Maxfield 2015-03-06 07:37:31 PST
Committed r181155: <http://trac.webkit.org/changeset/181155>