Bug 142371

Summary:

REGRESSION (r180782): Data Detector popovers are not dismissed on scroll or zoom

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch with a different approach	none
Patch	thorton: review+

Beth Dakin

Reported 2015-03-05 16:40:18 PST

After http://trac.webkit.org/changeset/180782 DD popovers are not dismissing on scroll. rdar://problem/20059224

Attachments
Patch (8.17 KB, patch) 2015-03-05 16:47 PST, Beth Dakin	no flags	Details Formatted Diff Diff
Patch with a different approach (4.98 KB, patch) 2015-03-06 11:46 PST, Beth Dakin	no flags	Details Formatted Diff Diff
Patch (5.09 KB, patch) 2015-03-06 12:10 PST, Beth Dakin	thorton: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2015-03-05 16:47:04 PST

Created attachment 248019 [details] Patch

Beth Dakin

Comment 2 2015-03-06 11:46:31 PST

Created attachment 248082 [details] Patch with a different approach

Tim Horton

Comment 3 2015-03-06 11:51:24 PST

Comment on attachment 248082 [details] Patch with a different approach View in context: https://bugs.webkit.org/attachment.cgi?id=248082&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:4416 > + if ([_data->_immediateActionController hasActiveImmediateAction]) { I wonder if we should do if isKey OR the other thing, because I somewhat fear our ability to keep track of hasActiveImmediateAction

Beth Dakin

Comment 4 2015-03-06 12:10:17 PST

Created attachment 248086 [details] Patch

Beth Dakin

Comment 5 2015-03-06 12:16:05 PST

http://trac.webkit.org/changeset/181176 Thanks Tim!

Note You need to log in before you can comment on or make changes to this bug.