Summary: | REGRESSION (r180782): Data Detector popovers are not dismissed on scroll or zoom | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, thorton | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Beth Dakin
2015-03-05 16:40:18 PST
Created attachment 248019 [details]
Patch
Created attachment 248082 [details]
Patch with a different approach
Comment on attachment 248082 [details] Patch with a different approach View in context: https://bugs.webkit.org/attachment.cgi?id=248082&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:4416 > + if ([_data->_immediateActionController hasActiveImmediateAction]) { I wonder if we should do if isKey OR the other thing, because I somewhat fear our ability to keep track of hasActiveImmediateAction Created attachment 248086 [details]
Patch
http://trac.webkit.org/changeset/181176 Thanks Tim! |