Bug 142371

Summary: REGRESSION (r180782): Data Detector popovers are not dismissed on scroll or zoom
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with a different approach
none
Patch thorton: review+

Description Beth Dakin 2015-03-05 16:40:18 PST
After http://trac.webkit.org/changeset/180782 DD popovers are not dismissing on scroll.

rdar://problem/20059224
Comment 1 Beth Dakin 2015-03-05 16:47:04 PST
Created attachment 248019 [details]
Patch
Comment 2 Beth Dakin 2015-03-06 11:46:31 PST
Created attachment 248082 [details]
Patch with a different approach
Comment 3 Tim Horton 2015-03-06 11:51:24 PST
Comment on attachment 248082 [details]
Patch with a different approach

View in context: https://bugs.webkit.org/attachment.cgi?id=248082&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:4416
> +    if ([_data->_immediateActionController hasActiveImmediateAction]) {

I wonder if we should do if isKey OR the other thing, because I somewhat fear our ability to keep track of hasActiveImmediateAction
Comment 4 Beth Dakin 2015-03-06 12:10:17 PST
Created attachment 248086 [details]
Patch
Comment 5 Beth Dakin 2015-03-06 12:16:05 PST
http://trac.webkit.org/changeset/181176

Thanks Tim!