Bug 142361

Summary: Fix the build when NEON_INTRINSICS is enabled
Product: WebKit Reporter: Sandy <sperez>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: cgarcia, commit-queue, dino, kondapallykalyan, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
A patch that fixes the bug none

Sandy
Reported 2015-03-05 13:14:14 PST
Project does not compile when ARM_NEON_INTRINSICS is enabled. In file 'WebKit/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp' variable 'isAlphaImage' is used as a function (i.e., isAlphaImage()) and in file 'WebKit/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h' a ';' is missing.
Attachments
A patch that fixes the bug (2.71 KB, patch)
2015-03-05 13:28 PST, Sandy 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sandy
Comment 1 2015-03-05 13:28:16 PST
Created attachment 247990 [details] A patch that fixes the bug
Csaba Osztrogonác
Comment 2 2015-03-05 15:09:55 PST
Just to note: r177000 caused the isAlphaImage issue and r170433 caused the return issue. Thanks for the fix. But it means that we didn't enable NEON on our ARM bots, but we should.
WebKit Commit Bot
Comment 3 2015-03-05 15:56:50 PST
Comment on attachment 247990 [details] A patch that fixes the bug Clearing flags on attachment: 247990 Committed r181110: <http://trac.webkit.org/changeset/181110>
WebKit Commit Bot
Comment 4 2015-03-05 15:56:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.