Bug 142344

Summary: Simple line layout: Merge TextFragmentIterator::findNextBreakablePosition() and TextFragmentIterator::findNextNonWhitespacePosition().
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142508    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Patch
none
Patch
none
Patch none

alan
Reported 2015-03-05 08:23:51 PST
To share the same logic.
Attachments
Patch (9.77 KB, patch)
2015-03-05 09:31 PST, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (495.98 KB, application/zip)
2015-03-05 10:05 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (298.28 KB, application/zip)
2015-03-05 10:20 PST, Build Bot 		no flags
Details
Patch (9.84 KB, patch)
2015-03-05 12:55 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.84 KB, patch)
2015-03-09 09:11 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2015-03-09 18:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-03-05 09:31:56 PST
Created attachment 247958 [details] Patch
Build Bot
Comment 2 2015-03-05 10:05:16 PST
Comment on attachment 247958 [details] Patch Attachment 247958 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5367984134553600 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2015-03-05 10:05:19 PST
Created attachment 247961 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-03-05 10:20:09 PST
Comment on attachment 247958 [details] Patch Attachment 247958 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4814558271111168 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2015-03-05 10:20:11 PST
Created attachment 247965 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
alan
Comment 6 2015-03-05 12:55:38 PST
Created attachment 247985 [details] Patch
alan
Comment 7 2015-03-09 09:11:11 PDT
Created attachment 248246 [details] Patch
Antti Koivisto
Comment 8 2015-03-09 09:22:58 PDT
Comment on attachment 248246 [details] Patch r=me
WebKit Commit Bot
Comment 9 2015-03-09 10:10:21 PDT
Comment on attachment 248246 [details] Patch Clearing flags on attachment: 248246 Committed r181268: <http://trac.webkit.org/changeset/181268>
WebKit Commit Bot
Comment 10 2015-03-09 10:10:27 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 11 2015-03-09 14:52:22 PDT
Did this cause bug 142507?
WebKit Commit Bot
Comment 12 2015-03-09 15:02:46 PDT
Re-opened since this is blocked by bug 142508
Alexey Proskuryakov
Comment 13 2015-03-09 15:06:25 PDT
Yes - ASan detects a mistake on so many tests that it's become useless for everything else. Will roll out.
alan
Comment 14 2015-03-09 18:19:53 PDT
Created attachment 248305 [details] Patch
WebKit Commit Bot
Comment 15 2015-03-10 08:16:54 PDT
Comment on attachment 248305 [details] Patch Clearing flags on attachment: 248305 Committed r181325: <http://trac.webkit.org/changeset/181325>
WebKit Commit Bot
Comment 16 2015-03-10 08:16:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.