Bug 142339

Summary:

Move disk cache classes to namespace

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	andersca: review+

Description Antti Koivisto 2015-03-05 06:36:44 PST

Move it to NetworkCache namespace.

Comment 1 Antti Koivisto 2015-03-05 06:40:31 PST

Created attachment 247949 [details]
patch

Comment 2 WebKit Commit Bot 2015-03-05 06:42:51 PST

Attachment 247949 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:104:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:105:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:78:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:97:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:247:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:328:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:376:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:429:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 19 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Antti Koivisto 2015-03-06 00:37:07 PST

https://trac.webkit.org/r181140

Comment 4 David Kilzer (:ddkilzer) 2015-03-06 01:42:11 PST

(In reply to comment #3)
> https://trac.webkit.org/r181140

Attempted a build fix for Yosemite open source buildbots (even though the ChangeLog says Mavericks, because I have trouble mapping nature pictures to names):
Committed r181147: <https://trac.webkit.org/changeset/181147>