Bug 142323

Summary:

Web Inspector: Add ObjectTreeBaseTreeElement to share functionality

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-03-04 21:02:26 PST

* SUMMARY
Add ObjectTreeBaseTreeElement to share functionality between different ObjectTree*TreeElement types.

  - Used by all:
    - property path support, UIStrings for failure
    - contextmenu support, Log Value / Copy Path to Property
    - "resolved value"

  - Used by Property and ArrayIndex:
    - handle invoking getters and thus getterValue || property.value

Comment 1 Radar WebKit Bug Importer 2015-03-04 21:02:52 PST

<rdar://problem/20050723>

Comment 2 Joseph Pecoraro 2015-03-04 21:06:42 PST

More shared code for:

  - general tree element construction
  - creation of readonly icons
  - function property string handling

Comment 3 Joseph Pecoraro 2015-03-04 21:25:06 PST

Created attachment 247928 [details]
[PATCH] Proposed Fix

Hard patch to follow...

Comment 4 Timothy Hatcher 2015-03-04 21:33:05 PST

Comment on attachment 247928 [details]
[PATCH] Proposed Fix

Very nice!

Comment 5 WebKit Commit Bot 2015-03-05 11:40:32 PST

Comment on attachment 247928 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247928

Committed r181089: <http://trac.webkit.org/changeset/181089>

Comment 6 WebKit Commit Bot 2015-03-05 11:40:36 PST

All reviewed patches have been landed.  Closing bug.