Bug 142305

Summary: Update inline media control icons for OSX
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142318    
Bug Blocks:    
Attachments:
Description Flags
patch dino: review+

Description Roger Fong 2015-03-04 13:21:17 PST
Update inline media control icons for OSX
This change will include the play button, volume button, fullscreen button, and caption button.
Comment 1 Roger Fong 2015-03-04 13:21:39 PST
rdar://problem/19997484
Comment 2 Roger Fong 2015-03-04 15:13:29 PST
Created attachment 247901 [details]
patch
Comment 3 Dean Jackson 2015-03-04 15:31:27 PST
Comment on attachment 247901 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247901&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134
> +    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>');

Did you create this image? This is fine, but it should be possible to use two <rect> elements.
Comment 4 Roger Fong 2015-03-04 15:34:07 PST
(In reply to comment #3)
> Comment on attachment 247901 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247901&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134
> > +    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>');
> 
> Did you create this image? This is fine, but it should be possible to use
> two <rect> elements.

I just followed what they were already doing in the previous pause svg code.
I can use rects too though.
Comment 5 Roger Fong 2015-03-04 16:06:33 PST
With rects:

http://trac.webkit.org/changeset/181046
Comment 6 Alexey Proskuryakov 2015-03-04 16:43:38 PST
This broke two tests: https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r181049%20(3326)/results.html

I'm sure that EWS would have told so if you could wait for it.
Comment 7 WebKit Commit Bot 2015-03-04 18:20:22 PST
Re-opened since this is blocked by bug 142318
Comment 8 Roger Fong 2015-03-05 13:11:34 PST
Recommitted after skipping the two test failures.
http://trac.webkit.org/changeset/181096