Summary: | Update inline media control icons for OSX | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, roger_fong | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 142318 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Roger Fong
2015-03-04 13:21:17 PST
Created attachment 247901 [details]
patch
Comment on attachment 247901 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=247901&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134 > + background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>'); Did you create this image? This is fine, but it should be possible to use two <rect> elements. (In reply to comment #3) > Comment on attachment 247901 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247901&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:134 > > + background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 15" fill="white"><path d="M 0,1 v 13 h 4 v -13 h -4 z"/><path d="M 8,1 v 13 h 4 v -13 h -4 z"/></svg>'); > > Did you create this image? This is fine, but it should be possible to use > two <rect> elements. I just followed what they were already doing in the previous pause svg code. I can use rects too though. With rects: http://trac.webkit.org/changeset/181046 This broke two tests: https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r181049%20(3326)/results.html I'm sure that EWS would have told so if you could wait for it. Re-opened since this is blocked by bug 142318 Recommitted after skipping the two test failures. http://trac.webkit.org/changeset/181096 |