| Summary: | [Mac] Set SystemUIFontSelect in DRT and WKTR | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, mmaxfield | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2015-03-04 12:51:01 PST
Created attachment 247884 [details]
proposed patch
Comment on attachment 247884 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=247884&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:72 > + [NSFont initialize]; This isn't listed in public API docs. Perhaps we should surround with respondsToSelector? Created attachment 247892 [details] with iOS build fix > This isn't listed in public API docs. Perhaps we should surround with respondsToSelector? I don't think so - it's a documented NSObject class method. And even if it wasn't, we would want tests to fail hard if it disappeared in the future. Waiting for EWS... Comment on attachment 247892 [details] with iOS build fix Clearing flags on attachment: 247892 Committed r181052: <http://trac.webkit.org/changeset/181052> All reviewed patches have been landed. Closing bug. |