Bug 142302

Summary: Enable selectors level 4's :lang() by default
Product: WebKit Reporter: Dhi Aurrahman <diorahman>
Component: New BugsAssignee: Dhi Aurrahman <diorahman>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Dhi Aurrahman
Reported 2015-03-04 12:36:54 PST
Enable selectors level 4's :lang() by default
Attachments
Patch (19.41 KB, patch)
2015-03-04 12:41 PST, Dhi Aurrahman 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.37 KB, patch)
2015-03-06 16:15 PST, Dhi Aurrahman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dhi Aurrahman
Comment 1 2015-03-04 12:41:18 PST
Created attachment 247883 [details] Patch
Benjamin Poulain
Comment 2 2015-03-06 10:10:53 PST
Comment on attachment 247883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247883&action=review Looks good to me. > Source/WebCore/css/CSSSelector.h:341 > + std::unique_ptr<Vector<AtomicString>> m_langArgumentList; // Used for :lang arguments Missing period at the end off the comment.
Dhi Aurrahman
Comment 3 2015-03-06 16:15:40 PST
Created attachment 248109 [details] Patch for landing
WebKit Commit Bot
Comment 4 2015-03-06 17:53:24 PST
Comment on attachment 248109 [details] Patch for landing Clearing flags on attachment: 248109 Committed r181197: <http://trac.webkit.org/changeset/181197>
WebKit Commit Bot
Comment 5 2015-03-06 17:53:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.