Bug 142302

Summary:

Enable selectors level 4's :lang() by default

Product:

WebKit

Reporter:

Dhi Aurrahman <diorahman>

Component:

New Bugs

Assignee:

Dhi Aurrahman <diorahman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Dhi Aurrahman 2015-03-04 12:36:54 PST

Enable selectors level 4's :lang() by default

Comment 1 Dhi Aurrahman 2015-03-04 12:41:18 PST

Created attachment 247883 [details]
Patch

Comment 2 Benjamin Poulain 2015-03-06 10:10:53 PST

Comment on attachment 247883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247883&action=review

Looks good to me.

> Source/WebCore/css/CSSSelector.h:341
> +            std::unique_ptr<Vector<AtomicString>> m_langArgumentList; // Used for :lang arguments

Missing period at the end off the comment.

Comment 3 Dhi Aurrahman 2015-03-06 16:15:40 PST

Created attachment 248109 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2015-03-06 17:53:24 PST

Comment on attachment 248109 [details]
Patch for landing

Clearing flags on attachment: 248109

Committed r181197: <http://trac.webkit.org/changeset/181197>

Comment 5 WebKit Commit Bot 2015-03-06 17:53:28 PST

All reviewed patches have been landed.  Closing bug.