WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142302
Enable selectors level 4's :lang() by default
https://bugs.webkit.org/show_bug.cgi?id=142302
Summary
Enable selectors level 4's :lang() by default
Dhi Aurrahman
Reported
2015-03-04 12:36:54 PST
Enable selectors level 4's :lang() by default
Attachments
Patch
(19.41 KB, patch)
2015-03-04 12:41 PST
,
Dhi Aurrahman
no flags
Details
Formatted Diff
Diff
Patch for landing
(19.37 KB, patch)
2015-03-06 16:15 PST
,
Dhi Aurrahman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dhi Aurrahman
Comment 1
2015-03-04 12:41:18 PST
Created
attachment 247883
[details]
Patch
Benjamin Poulain
Comment 2
2015-03-06 10:10:53 PST
Comment on
attachment 247883
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=247883&action=review
Looks good to me.
> Source/WebCore/css/CSSSelector.h:341 > + std::unique_ptr<Vector<AtomicString>> m_langArgumentList; // Used for :lang arguments
Missing period at the end off the comment.
Dhi Aurrahman
Comment 3
2015-03-06 16:15:40 PST
Created
attachment 248109
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2015-03-06 17:53:24 PST
Comment on
attachment 248109
[details]
Patch for landing Clearing flags on attachment: 248109 Committed
r181197
: <
http://trac.webkit.org/changeset/181197
>
WebKit Commit Bot
Comment 5
2015-03-06 17:53:28 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug