Bug 142299

Summary: move content extensions tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Patch thorton: review+

Alex Christensen
Reported 2015-03-04 12:17:34 PST
I'm not sure where the name usercontentfilters came from. Let's move the tests to a subdirectory called contentextensions to match the WebCore directory name.
Attachments
Patch (22.28 KB, patch)
2015-03-04 12:19 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (23.26 KB, patch)
2015-03-04 12:25 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (853.37 KB, application/zip)
2015-03-04 13:50 PST, Build Bot 		no flags
Details
Patch (27.06 KB, patch)
2015-03-04 14:02 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-03-04 12:19:25 PST
Created attachment 247879 [details] Patch
Alex Christensen
Comment 2 2015-03-04 12:19:55 PST
Remind myself to remove the empty directory when landing.
Alex Christensen
Comment 3 2015-03-04 12:25:40 PST
Created attachment 247880 [details] Patch
Alex Christensen
Comment 4 2015-03-04 13:23:27 PST
Comment on attachment 247880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247880&action=review > Tools/WebKitTestRunner/mac/TestControllerMac.mm:113 > WKRetainPtr<WKStringRef> contentFilterStringWK = adoptWK(WKStringCreateWithCFString((CFStringRef)contentFilterString)); > WKRetainPtr<WKUserContentFilterRef> filter = adoptWK(WKUserContentFilterCreate(name.get(), contentFilterStringWK.get())); Also change contentFilterStringWK to contentExtensionStringWK
Build Bot
Comment 5 2015-03-04 13:50:30 PST
Comment on attachment 247880 [details] Patch Attachment 247880 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5725994086301696 New failing tests: http/tests/contentextensions/basic-filter.html
Build Bot
Comment 6 2015-03-04 13:50:33 PST
Created attachment 247893 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Alex Christensen
Comment 7 2015-03-04 14:02:57 PST
Created attachment 247895 [details] Patch
Alex Christensen
Comment 8 2015-03-04 14:04:31 PST
Also moved platform/mac/http/tests/usercontentfilter/basic-filter-expected.txt to http/tests/contentextensions/basic-filter-expected.txt because all the other expectations were there and it is only enabled in platform/mac-wk2/TestExpectations
Tim Horton
Comment 9 2015-03-04 14:08:20 PST
Comment on attachment 247895 [details] Patch rs=me
Alex Christensen
Comment 10 2015-03-04 14:11:34 PST
done https://trac.webkit.org/r181031
Note You need to log in before you can comment on or make changes to this bug.