Bug 142299

Summary: move content extensions tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Patch thorton: review+

Description Alex Christensen 2015-03-04 12:17:34 PST
I'm not sure where the name usercontentfilters came from.  Let's move the tests to a subdirectory called contentextensions to match the WebCore directory name.
Comment 1 Alex Christensen 2015-03-04 12:19:25 PST
Created attachment 247879 [details]
Patch
Comment 2 Alex Christensen 2015-03-04 12:19:55 PST
Remind myself to remove the empty directory when landing.
Comment 3 Alex Christensen 2015-03-04 12:25:40 PST
Created attachment 247880 [details]
Patch
Comment 4 Alex Christensen 2015-03-04 13:23:27 PST
Comment on attachment 247880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247880&action=review

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:113
>      WKRetainPtr<WKStringRef> contentFilterStringWK = adoptWK(WKStringCreateWithCFString((CFStringRef)contentFilterString));
>      WKRetainPtr<WKUserContentFilterRef> filter = adoptWK(WKUserContentFilterCreate(name.get(), contentFilterStringWK.get()));

Also change contentFilterStringWK to contentExtensionStringWK
Comment 5 Build Bot 2015-03-04 13:50:30 PST
Comment on attachment 247880 [details]
Patch

Attachment 247880 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5725994086301696

New failing tests:
http/tests/contentextensions/basic-filter.html
Comment 6 Build Bot 2015-03-04 13:50:33 PST
Created attachment 247893 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Alex Christensen 2015-03-04 14:02:57 PST
Created attachment 247895 [details]
Patch
Comment 8 Alex Christensen 2015-03-04 14:04:31 PST
Also moved platform/mac/http/tests/usercontentfilter/basic-filter-expected.txt to http/tests/contentextensions/basic-filter-expected.txt because all the other expectations were there and it is only enabled in platform/mac-wk2/TestExpectations
Comment 9 Tim Horton 2015-03-04 14:08:20 PST
Comment on attachment 247895 [details]
Patch

rs=me
Comment 10 Alex Christensen 2015-03-04 14:11:34 PST
done https://trac.webkit.org/r181031