Summary: | move content extensions tests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
Component: | Tools / Tests | Assignee: | Alex Christensen <achristensen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alex Christensen
2015-03-04 12:17:34 PST
Created attachment 247879 [details]
Patch
Remind myself to remove the empty directory when landing. Created attachment 247880 [details]
Patch
Comment on attachment 247880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247880&action=review > Tools/WebKitTestRunner/mac/TestControllerMac.mm:113 > WKRetainPtr<WKStringRef> contentFilterStringWK = adoptWK(WKStringCreateWithCFString((CFStringRef)contentFilterString)); > WKRetainPtr<WKUserContentFilterRef> filter = adoptWK(WKUserContentFilterCreate(name.get(), contentFilterStringWK.get())); Also change contentFilterStringWK to contentExtensionStringWK Comment on attachment 247880 [details] Patch Attachment 247880 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5725994086301696 New failing tests: http/tests/contentextensions/basic-filter.html Created attachment 247893 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 247895 [details]
Patch
Also moved platform/mac/http/tests/usercontentfilter/basic-filter-expected.txt to http/tests/contentextensions/basic-filter-expected.txt because all the other expectations were there and it is only enabled in platform/mac-wk2/TestExpectations Comment on attachment 247895 [details]
Patch
rs=me
|