Bug 142294

Summary: Message UI process when contentSize changes
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Beth Dakin 2015-03-04 10:45:08 PST 
We should message the UI process when contentSize changes. This will enable us to account for dynamic heights in our scrolling performance test.

rdar://problem/19963165
Comment 1 Beth Dakin 2015-03-04 10:49:11 PST 
Created attachment 247869 [details]
Patch
Comment 2 Andreas Kling 2015-03-04 11:02:36 PST 
Comment on attachment 247869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247869&action=review

r=me

> Source/WebKit2/UIProcess/PageClient.h:-158
> -#if PLATFORM(EFL)
>      virtual void didChangeContentSize(const WebCore::IntSize&) = 0;
> -#endif

Since you're unmasking a pure virtual here, you'll need to update the Gtk+ subclass of PageClient as well.
Comment 3 Beth Dakin 2015-03-04 13:46:31 PST 
(In reply to comment #2)
> Comment on attachment 247869 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247869&action=review
> 
> r=me
> 
> > Source/WebKit2/UIProcess/PageClient.h:-158
> > -#if PLATFORM(EFL)
> >      virtual void didChangeContentSize(const WebCore::IntSize&) = 0;
> > -#endif
> 
> Since you're unmasking a pure virtual here, you'll need to update the Gtk+
> subclass of PageClient as well.

Thanks Andreas! I fixed this.

http://trac.webkit.org/changeset/181023