Bug 142290

Summary:

Web Inspector: TimelineViews should be displayed in a ContentViewContainer

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none

Description Brian Burg 2015-03-04 09:49:12 PST

TimelineRecordingContentView duplicates a bunch of logic for managing sub-views. We can give it a real ContentViewContainer to manage switching out the TimelineViews.

Comment 1 Radar WebKit Bug Importer 2015-03-04 09:49:35 PST

<rdar://problem/20039418>

Comment 2 Brian Burg 2015-03-04 10:58:41 PST

Created attachment 247870 [details]
Proposed Fix

Comment 3 Timothy Hatcher 2015-03-04 11:32:16 PST

Comment on attachment 247870 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247870&action=review

Very nice.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:165
> +        return (contentView instanceof WebInspector.TimelineView) ? contentView : null;

Nit: No need for ().

Comment 4 WebKit Commit Bot 2015-03-04 12:24:27 PST

Comment on attachment 247870 [details]
Proposed Fix

Clearing flags on attachment: 247870

Committed r181011: <http://trac.webkit.org/changeset/181011>

Comment 5 WebKit Commit Bot 2015-03-04 12:24:32 PST

All reviewed patches have been landed.  Closing bug.