Bug 142260 – [Win] Windows port is missing custom renderer for attachments

• Component: Tools / Tests
• Status: NEW

[Brent Fulgham]

The following layout test is failing on Windows.

fast/attachment/attachment-label-highlight.html

The failure looks like the following:

--- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-label-highlight-expected.txt
+++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/attachment/attachment-label-highlight-actual.txt
@@ -1,14 +1,13 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x108
-  RenderBlock {HTML} at (0,0) size 800x108
-    RenderBody {BODY} at (8,8) size 784x92
-      RenderAttachment {ATTACHMENT} at (0,0) size 60x77
-      RenderAttachment {ATTACHMENT} at (60,0) size 90x92
-      RenderAttachment {ATTACHMENT} at (150,0) size 90x92
-      RenderAttachment {ATTACHMENT} at (240,0) size 96x92
-      RenderAttachment {ATTACHMENT} at (336,0) size 102x92
-      RenderAttachment {ATTACHMENT} at (438,0) size 106x92
+layer at (0,0) size 800x8
+  RenderBlock {HTML} at (0,0) size 800x8
+    RenderBody {BODY} at (8,8) size 784x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
+      RenderInline {ATTACHMENT} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
-selection start: position 0 of child 2 {ATTACHMENT} of body
-selection end:   position 1 of child 7 {ATTACHMENT} of body
+caret: position 0 of body

[Brent Fulgham]

On Windows, the various {ATTACHMENT} elements are empty, and reporting as the wrong render type.

[Brent Fulgham]

Based on Bug 142214, it looks like RenderThemeWin needs an implementation of this logic.

[Tim Horton]

I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does Windows fall back on Mac still? Otherwise, why is it not using the platform independent baselines?

> Based on Bug 142214, it looks like RenderThemeWin needs an implementation of this logic.

I wouldn't worry much about that yet.

[Brent Fulgham]

(In reply to comment #3)
> I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does
> Windows fall back on Mac still? Otherwise, why is it not using the platform
> independent baselines?

It does fall back to mac, but unfortunately the bots are not up to date with your patch. That will *probably* resolve this.

[Tim Horton]

(In reply to comment #4)
> (In reply to comment #3)
> > I landed non-Mac baselines in http://trac.webkit.org/changeset/180975; does
> > Windows fall back on Mac still? Otherwise, why is it not using the platform
> > independent baselines?
> 
> It does fall back to mac, but unfortunately the bots are not up to date with
> your patch. That will *probably* resolve this.

Well, no, probably not, because Mac has results that are different than everyone else. So if Windows falls back there it will still fail.

[Brent Fulgham]

This bug is the cause of 'fast/attachment/attachment-rendering.html' failing as well.