Bug 142259

Summary:

[Content Extensions] Split parsing and compiling of content extensions into their own files

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Sam Weinig 2015-03-03 21:28:20 PST

[Content Extensions] Split parsing and compiling of content extensions into their own files

Comment 1 Sam Weinig 2015-03-03 21:43:23 PST

Created attachment 247838 [details]
Patch

Comment 2 WebKit Commit Bot 2015-03-03 21:46:32 PST

Attachment 247838 [details] did not pass style-queue:


ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:40:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/contentextensions/ContentExtensionsBackend.h:55:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2015-03-04 08:38:37 PST

Comment on attachment 247838 [details]
Patch

rs=me

Comment 4 Sam Weinig 2015-03-04 08:41:52 PST

Committed r181000: <http://trac.webkit.org/changeset/181000>