Bug 142255

Summary: [Content Filtering] Make it easier to add new content filters
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128858    
Attachments:
Description Flags
Patch sam: review+

Andy Estes
Reported 2015-03-03 20:39:10 PST
[Content Filtering] Make it easier to add new content filters
Attachments
Patch (40.33 KB, patch)
2015-03-03 21:55 PST, Andy Estes 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-03-03 21:55:47 PST
Created attachment 247839 [details] Patch
WebKit Commit Bot
Comment 2 2015-03-03 21:57:36 PST
Attachment 247839 [details] did not pass style-queue: ERROR: Source/WebCore/platform/cocoa/ParentalControlsContentFilter.mm:60: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:53: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:79: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:94: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 3 2015-03-04 14:43:59 PST
Committed r181037: <http://trac.webkit.org/changeset/181037>
Note You need to log in before you can comment on or make changes to this bug.