Bug 142252

Summary: Remove WK_AVAILABLE and related macros when we cannot determine iOS/Mac version
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix ddkilzer: review+

Description Joseph Pecoraro 2015-03-03 18:11:23 PST 
* SUMMARY
Better build fix when PLATFORM_NAME is unknown/missing. In such cases, we cannot determine the iOS/Mac version numbers, so just remove WK_AVAILABLE / WK_DEPRECATED macros that may contain WK_MAC_TBA/WK_IOS_TBA in the postprocess build step so we don't output a broken NS macro.
Comment 1 Joseph Pecoraro 2015-03-03 18:15:06 PST 
Created attachment 247823 [details]
[PATCH] Proposed Fix
Comment 2 David Kilzer (:ddkilzer) 2015-03-04 09:43:55 PST 
Comment on attachment 247823 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=247823&action=review

r=me

> Source/WebKit2/mac/postprocess-framework-headers.sh:50
> +            if [[ -n $OSX_VERSION ]] && [[ -n $IOS_VERSION ]]; then

Should the variables be double-quoted in case they're not set?

            if [[ -n "$OSX_VERSION" ]] && [[ -n "$IOS_VERSION" ]]; then
Comment 3 Joseph Pecoraro 2015-03-04 10:49:38 PST 
http://trac.webkit.org/changeset/181004