| Summary: | [Content Filtering] Separate unblock handling into its own class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, japhet | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 128858 | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2015-03-03 17:58:59 PST
Created attachment 247825 [details]
Patch
Attachment 247825 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ContentFilterUnblockHandler.h:45: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247825&action=review r=me > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:66 > + static const char contentFilterScheme[] = "x-apple-content-filter"; > + return contentFilterScheme; return "x-apple-content-filter"; Committed r180985: <http://trac.webkit.org/changeset/180985> |