Bug 142251 – [Content Filtering] Separate unblock handling into its own class

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

[Content Filtering] Separate unblock handling into its own class

[Andy Estes]

Created attachment 247825 [details]
Patch

[WebKit Commit Bot]

Attachment 247825 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ContentFilterUnblockHandler.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 247825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247825&action=review

r=me

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:66
> +    static const char contentFilterScheme[] = "x-apple-content-filter";
> +    return contentFilterScheme;

return "x-apple-content-filter";

[Andy Estes]

Committed r180985: <http://trac.webkit.org/changeset/180985>