Bug 142242

Summary: [Mac] Track localized name follows locale instead of primary language
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: MediaAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-03-03 16:22:36 PST
We always use AppleLanguages for choosing localized strings (often via CFBundle), except for localized language names in track names. These are localized using the system locale. I think that this is inconsistent and incorrect. This is observable on tests, media/video-controls-captions-trackmenu-localized.html and media/video-controls-captions-trackmenu-sorted.html fail when system locale is non-English. Also, one of these tests actually attempts to test Japanese, and fails, getting English results instead. rdar://problem/20000365
Attachments
proposed fix (3.63 KB, patch)
2015-03-03 16:27 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-03-03 16:27:12 PST
Created attachment 247809 [details] proposed fix
Eric Carlson
Comment 2 2015-03-03 16:56:35 PST
Comment on attachment 247809 [details] proposed fix Thank you!
WebKit Commit Bot
Comment 3 2015-03-03 19:34:06 PST
Comment on attachment 247809 [details] proposed fix Clearing flags on attachment: 247809 Committed r180984: <http://trac.webkit.org/changeset/180984>
WebKit Commit Bot
Comment 4 2015-03-03 19:34:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.