Bug 142242

Summary:

[Mac] Track localized name follows locale instead of primary language

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Media

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-03-03 16:22:36 PST

We always use AppleLanguages for choosing localized strings (often via CFBundle), except for localized language names in track names. These are localized using the system locale.

I think that this is inconsistent and incorrect.

This is observable on tests, media/video-controls-captions-trackmenu-localized.html and media/video-controls-captions-trackmenu-sorted.html fail when system locale is non-English. Also, one of these tests actually attempts to test Japanese, and fails, getting English results instead.

rdar://problem/20000365

Comment 1 Alexey Proskuryakov 2015-03-03 16:27:12 PST

Created attachment 247809 [details]
proposed fix

Comment 2 Eric Carlson 2015-03-03 16:56:35 PST

Comment on attachment 247809 [details]
proposed fix

Thank you!

Comment 3 WebKit Commit Bot 2015-03-03 19:34:06 PST

Comment on attachment 247809 [details]
proposed fix

Clearing flags on attachment: 247809

Committed r180984: <http://trac.webkit.org/changeset/180984>

Comment 4 WebKit Commit Bot 2015-03-03 19:34:10 PST

All reviewed patches have been landed.  Closing bug.