Bug 142242 - [Mac] Track localized name follows locale instead of primary language
Summary: [Mac] Track localized name follows locale instead of primary language
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-03 16:22 PST by Alexey Proskuryakov
Modified: 2015-03-03 19:34 PST (History)
3 users (show)

See Also:


Attachments
proposed fix (3.63 KB, patch)
2015-03-03 16:27 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-03 16:22:36 PST
We always use AppleLanguages for choosing localized strings (often via CFBundle), except for localized language names in track names. These are localized using the system locale.

I think that this is inconsistent and incorrect.

This is observable on tests, media/video-controls-captions-trackmenu-localized.html and media/video-controls-captions-trackmenu-sorted.html fail when system locale is non-English. Also, one of these tests actually attempts to test Japanese, and fails, getting English results instead.

rdar://problem/20000365
Comment 1 Alexey Proskuryakov 2015-03-03 16:27:12 PST
Created attachment 247809 [details]
proposed fix
Comment 2 Eric Carlson 2015-03-03 16:56:35 PST
Comment on attachment 247809 [details]
proposed fix

Thank you!
Comment 3 WebKit Commit Bot 2015-03-03 19:34:06 PST
Comment on attachment 247809 [details]
proposed fix

Clearing flags on attachment: 247809

Committed r180984: <http://trac.webkit.org/changeset/180984>
Comment 4 WebKit Commit Bot 2015-03-03 19:34:10 PST
All reviewed patches have been landed.  Closing bug.