Bug 142231

Summary:

bmalloc: Miscellaneous cleanup

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Geoffrey Garen 2015-03-03 12:22:08 PST

bmalloc: Miscellaneous cleanup

Comment 1 Geoffrey Garen 2015-03-03 12:28:04 PST

Created attachment 247778 [details]
Patch

Comment 2 Geoffrey Garen 2015-03-03 12:34:34 PST

Created attachment 247780 [details]
Patch

Comment 3 Andreas Kling 2015-03-03 13:13:36 PST

Comment on attachment 247780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247780&action=review

r=me

> Source/bmalloc/bmalloc/Vector.h:92
> -    vmDeallocate(m_buffer, vmSize(m_capacity * sizeof(T)));
> +    if (m_buffer)
> +        vmDeallocate(m_buffer, vmSize(m_capacity * sizeof(T)));

Whoops :o

Comment 4 Geoffrey Garen 2015-03-03 13:48:10 PST

Committed r180953: <http://trac.webkit.org/changeset/180953>