Bug 142197

Summary:

SpeculativeJIT::emitAllocateArguments() should be a bit faster, and shouldn't do destructor initialization

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

141174

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2015-03-02 16:28:35 PST

Patch forthcoming.

Comment 1 Filip Pizlo 2015-03-02 16:33:45 PST

Created attachment 247717 [details]
the patch

Comment 2 Geoffrey Garen 2015-03-02 16:36:16 PST

Comment on attachment 247717 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247717&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        (JSC::DFG::SpeculativeJIT::emitAllocateArguments): Use shift instead of mul, since mul doesn't automatically strength-reduce to shift. Also lass the structure as a TrustedImmPtr.

lass => pass

Comment 3 Filip Pizlo 2015-03-02 16:46:33 PST

Landed in http://trac.webkit.org/changeset/180909