Bug 142197 - SpeculativeJIT::emitAllocateArguments() should be a bit faster, and shouldn't do destructor initialization
Summary: SpeculativeJIT::emitAllocateArguments() should be a bit faster, and shouldn't...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141174
  Show dependency tree / graph
 
Reported: 2015-03-02 16:28 PST by Filip Pizlo
Modified: 2015-03-02 16:46 PST (History)
0 users

See Also:

Attachments
the patch (2.98 KB, patch)
2015-03-02 16:33 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-02 16:28:35 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-03-02 16:33:45 PST 
Created attachment 247717 [details]
the patch
Comment 2 Geoffrey Garen 2015-03-02 16:36:16 PST 
Comment on attachment 247717 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247717&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        (JSC::DFG::SpeculativeJIT::emitAllocateArguments): Use shift instead of mul, since mul doesn't automatically strength-reduce to shift. Also lass the structure as a TrustedImmPtr.

lass => pass
Comment 3 Filip Pizlo 2015-03-02 16:46:33 PST 
Landed in http://trac.webkit.org/changeset/180909