| Summary: | Fetch cache origins from the network process | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Carlsson
2015-02-28 13:12:30 PST
Created attachment 247610 [details]
Patch
Attachment 247610 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:289: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:304: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247611 [details]
Patch
Attachment 247611 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:291: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247611&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:262 > +static void fetchDiskCacheOrigins(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler) Why “origins” and not “entires”? > Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:114 > + if (dataTypes & WebsiteDataTypeDiskCache && !isNonPersistentStore) The double negative is confusing. Why not change the boolean to isPersistentStore? Committed r180841: <http://trac.webkit.org/changeset/180841> |