Summary: | Add a "block-cookies" rule to the user content filter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, japhet | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2015-02-27 14:31:32 PST
Created attachment 247553 [details]
Patch v1
Comment on attachment 247553 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=247553&action=review This seems ok, except the ContentFilterAction enum, which could evolve into something completely different. I have a few questions, though: > Source/WebCore/contentextensions/ContentExtensionsManager.cpp:101 > else if (actionType != "block" && actionType != "") { I think this should just be else. > Source/WebCore/page/UserContentController.h:52 > +enum class ContentFilterAction { This will eventually be an index into a data structure I'll make. > Source/WebCore/page/UserContentController.h:53 > + Load, I think Load should just be the absence of Block in the returned vector of actionsForURL > Source/WebCore/page/UserContentController.h:94 > + ContentFilterAction actionForURL(const URL&); Will there only be one? Should we return a vector of actions? Comment on attachment 247553 [details]
Patch v1
Ok. We'll change these things later.
|