Bug 142096

Summary: Make ActiveDOMObject::canSuspend() pure virtual
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, koivisto
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2015-02-27 13:12:49 PST 
Make ActiveDOMObject::canSuspend() pure virtual so that people at least try to provide an implementation for it. The default implementation was returning false unconditionally and thus was preventing pages from entering the PageCache.

Radar: <rdar://problem/19923085>
Comment 1 Chris Dumez 2015-02-27 13:15:49 PST 
Created attachment 247540 [details]
Patch
Comment 2 Chris Dumez 2015-02-27 13:22:10 PST 
Created attachment 247541 [details]
Patch
Comment 3 Chris Dumez 2015-02-27 13:45:18 PST 
Created attachment 247547 [details]
Patch
Comment 4 Chris Dumez 2015-02-27 15:02:01 PST 
Created attachment 247559 [details]
Patch
Comment 5 Chris Dumez 2015-02-27 15:50:19 PST 
Created attachment 247568 [details]
Patch
Comment 6 Chris Dumez 2015-02-27 17:05:42 PST 
Comment on attachment 247568 [details]
Patch

Clearing flags on attachment: 247568

Committed r180801: <http://trac.webkit.org/changeset/180801>
Comment 7 Chris Dumez 2015-02-27 17:05:52 PST 
All reviewed patches have been landed.  Closing bug.