Bug 142092

Summary:

Add infrastructure for handling website data in the network process

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Anders Carlsson 2015-02-27 11:32:24 PST

Add infrastructure for handling website data in the network process

Comment 1 Anders Carlsson 2015-02-27 11:46:46 PST

Created attachment 247530 [details]
Patch

Comment 2 WebKit Commit Bot 2015-02-27 11:49:39 PST

Attachment 247530 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2015-02-27 11:51:36 PST

Created attachment 247531 [details]
Patch

Comment 4 WebKit Commit Bot 2015-02-27 11:52:34 PST

Attachment 247531 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andreas Kling 2015-02-27 12:08:40 PST

Comment on attachment 247531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247531&action=review

r=me

> Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:144
> +    Vector<SecurityOriginData> originData;
> +    for (auto& origin : origins)
> +        originData.append(SecurityOriginData::fromSecurityOrigin(*origin));

Could use reserveInitialCapacity + uncheckedAppend here.

Comment 6 Anders Carlsson 2015-02-27 12:14:40 PST

Committed r180773: <http://trac.webkit.org/changeset/180773>