Bug 142092

Summary: Add infrastructure for handling website data in the network process
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2015-02-27 11:32:24 PST
Add infrastructure for handling website data in the network process
Attachments
Patch (19.32 KB, patch)
2015-02-27 11:46 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (18.56 KB, patch)
2015-02-27 11:51 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-02-27 11:46:46 PST
Created attachment 247530 [details] Patch
WebKit Commit Bot
Comment 2 2015-02-27 11:49:39 PST
Attachment 247530 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-02-27 11:51:36 PST
Created attachment 247531 [details] Patch
WebKit Commit Bot
Comment 4 2015-02-27 11:52:34 PST
Attachment 247531 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:419: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:421: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 5 2015-02-27 12:08:40 PST
Comment on attachment 247531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247531&action=review r=me > Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:144 > + Vector<SecurityOriginData> originData; > + for (auto& origin : origins) > + originData.append(SecurityOriginData::fromSecurityOrigin(*origin)); Could use reserveInitialCapacity + uncheckedAppend here.
Anders Carlsson
Comment 6 2015-02-27 12:14:40 PST
Committed r180773: <http://trac.webkit.org/changeset/180773>
Note You need to log in before you can comment on or make changes to this bug.