Bug 142080

Summary: Implement ES6 StringIterator
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, darin, fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141351    
Bug Blocks:    
Attachments:
Description Flags
rev1 prototype
none
prototype rev2
none
Patch
none
Patch none

Description Yusuke Suzuki 2015-02-27 02:25:16 PST 
Implement ES6 StringIterator
Comment 1 Yusuke Suzuki 2015-02-27 03:40:12 PST 
Created attachment 247507 [details]
rev1 prototype

prototype. not including build configuration for OSX and Windows yet. And this patch requires https://bugs.webkit.org/show_bug.cgi?id=141351 change.
Comment 2 Yusuke Suzuki 2015-02-27 09:14:27 PST 
Created attachment 247516 [details]
prototype rev2

Update for Windows / OSX build
Comment 3 WebKit Commit Bot 2015-03-02 04:07:08 PST 
Attachment 247516 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/StringIteratorPrototype.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2015-03-03 10:15:01 PST 
Created attachment 247767 [details]
Patch
Comment 5 Filip Pizlo 2015-03-04 20:10:56 PST 
Comment on attachment 247767 [details]
Patch

LGTM.  I can r+ once you're ready.
Comment 6 Yusuke Suzuki 2015-03-05 08:39:01 PST 
Created attachment 247952 [details]
Patch
Comment 7 WebKit Commit Bot 2015-03-05 08:41:02 PST 
Attachment 247952 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/StringIteratorPrototype.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yusuke Suzuki 2015-03-05 08:42:40 PST 
(In reply to comment #5)
> Comment on attachment 247767 [details]
> Patch
> 
> LGTM.  I can r+ once you're ready.

Great! I've landed https://trac.webkit.org/changeset/181077, rebased my patch and marked r? :D
Comment 9 Yusuke Suzuki 2015-03-05 09:41:49 PST 
Comment on attachment 247952 [details]
Patch

Thank you!
Comment 10 WebKit Commit Bot 2015-03-05 10:27:52 PST 
Comment on attachment 247952 [details]
Patch

Clearing flags on attachment: 247952

Committed r181084: <http://trac.webkit.org/changeset/181084>
Comment 11 WebKit Commit Bot 2015-03-05 10:27:57 PST 
All reviewed patches have been landed.  Closing bug.