Bug 142073

Summary: Web Inspector: Add a subtle blue background for selected console messages
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=140580
Attachments:
Description Flags
Animated GIF
none
Patch none

Nikita Vasilyev
Reported 2015-02-26 20:11:50 PST
Created attachment 247487 [details] Animated GIF In addition to that, also add a subtle blue border.
Attachments
Animated GIF (481.27 KB, image/gif)
2015-02-26 20:11 PST, Nikita Vasilyev 		no flags
Details
Patch (2.62 KB, patch)
2015-02-26 20:23 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-26 20:17:16 PST
<rdar://problem/19981097>
Nikita Vasilyev
Comment 2 2015-02-26 20:23:56 PST
Created attachment 247490 [details] Patch
Timothy Hatcher
Comment 3 2015-02-26 20:45:59 PST
Comment on attachment 247490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247490&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:70 > + z-index: 10; Why is the z-index needed?
Timothy Hatcher
Comment 4 2015-02-26 20:47:17 PST
Very nice!
Nikita Vasilyev
Comment 5 2015-02-26 21:01:27 PST
(In reply to comment #3) > Comment on attachment 247490 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247490&action=review > > > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:70 > > + z-index: 10; > > Why is the z-index needed? To hide the gaps between the selection bars: https://cloudup.com/cDEHWAyp8AF
WebKit Commit Bot
Comment 6 2015-02-26 21:32:26 PST
Comment on attachment 247490 [details] Patch Clearing flags on attachment: 247490 Committed r180725: <http://trac.webkit.org/changeset/180725>
WebKit Commit Bot
Comment 7 2015-02-26 21:32:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.