Summary: | The bool returning form of BytecodeGenerator::addVar() can be removed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, mark.lam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 142067 | ||||||||
Bug Blocks: | 141174 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-02-26 16:46:22 PST
Created attachment 247467 [details]
the patch
Attachment 247467 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "ident" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "constantMode" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:616: The parameter name "watchMode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247467 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/180711 This may have caused a bunch of Debug assertions Windows. I'm trying to debug locally. Re-opened since this is blocked by bug 142067 Created attachment 247478 [details]
patch for commit of assertion failure fix.
Fix for assertion failure landed in r180719: <http://trac.webkit.org/r180719>. (In reply to comment #8) > Fix for assertion failure landed in r180719: > <http://trac.webkit.org/r180719>. Thanks! |