Bug 142047

Summary: Make WKPageGroupRemoveAllUserContentFilters actually remove all user content filters
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 ggaren: review+

Brady Eidson
Reported 2015-02-26 11:05:35 PST
Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters http://trac.webkit.org/changeset/178869 added this SPI but implemented it incorrectly.
Attachments
Patch v1 (2.41 KB, patch)
2015-02-26 11:10 PST, Brady Eidson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-02-26 11:10:48 PST
Created attachment 247433 [details] Patch v1
Geoffrey Garen
Comment 2 2015-02-26 11:28:05 PST
Comment on attachment 247433 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=247433&action=review r=me Plz fix tyop. > LayoutTests/ChangeLog:3 > + Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters Should be "remove". > Source/WebKit2/ChangeLog:3 > + Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters Should be "remove". > Source/WebKit2/UIProcess/API/C/WKPageGroup.cpp:95 > + toImpl(pageGroupRef)->removeAllUserContentFilters(); lol
Brady Eidson
Comment 3 2015-02-26 11:30:19 PST
http://trac.webkit.org/changeset/180687
Note You need to log in before you can comment on or make changes to this bug.