Bug 142047

Summary: Make WKPageGroupRemoveAllUserContentFilters actually remove all user content filters
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 ggaren: review+

Description Brady Eidson 2015-02-26 11:05:35 PST
Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

http://trac.webkit.org/changeset/178869 added this SPI but implemented it incorrectly.
Comment 1 Brady Eidson 2015-02-26 11:10:48 PST
Created attachment 247433 [details]
Patch v1
Comment 2 Geoffrey Garen 2015-02-26 11:28:05 PST
Comment on attachment 247433 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=247433&action=review

r=me

Plz fix tyop.

> LayoutTests/ChangeLog:3
> +        Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

Should be "remove".

> Source/WebKit2/ChangeLog:3
> +        Make WKPageGroupRemoveAllUserContentFilters actually remote all user content filters

Should be "remove".

> Source/WebKit2/UIProcess/API/C/WKPageGroup.cpp:95
> +    toImpl(pageGroupRef)->removeAllUserContentFilters();

lol
Comment 3 Brady Eidson 2015-02-26 11:30:19 PST
http://trac.webkit.org/changeset/180687