| Summary: | [webkitpy] Remove unused functions from git.py | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | commit-queue, dbates, glenn, matthew_hanson, ossy, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Csaba Osztrogonác
2015-02-26 06:06:01 PST
Created attachment 247423 [details]
Patch
These functions were added by http://trac.webkit.org/changeset/175606 and http://trac.webkit.org/changeset/175605 , but weren't used ever. Let's remove them. Comment on attachment 247423 [details]
Patch
Oh, I think these are used by Apple internal tools.
It would be great to have a reference to it somewhere. I hear what you're saying, Csaba. But can't it also be useful in and of itself? E.g. for use in personal workflow automation scripts? The git.py module is supposed to be an interface to the Git tool, and cherrypick merging is something that a person with a merge-based workflow would use fairly often. (In reply to comment #5) > I hear what you're saying, Csaba. But can't it also be useful in and of > itself? E.g. for use in personal workflow automation scripts? Of course it can be. But I thought git.py is only used by webkitpy scripts, that's why thought it is unused. > The git.py module is supposed to be an interface to the Git tool, and > cherrypick merging is something that a person with a merge-based workflow > would use fairly often. See. I could imagine a publicly available webkit-patch cherry-pick <svn-revision> command. I assume you use these functions for similar use-case. |