Bug 142043

Summary: [webkitpy] Remove unused functions from git.py
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, dbates, glenn, matthew_hanson, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review-, rniwa: commit-queue-

Csaba Osztrogonác
Reported 2015-02-26 06:06:01 PST
[webkitpy] Remove unused functions from git.py
Attachments
Patch (2.12 KB, patch)
2015-02-26 06:06 PST, Csaba Osztrogonác 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-02-26 06:06:15 PST
Created attachment 247423 [details] Patch
Csaba Osztrogonác
Comment 2 2015-02-26 06:08:44 PST
These functions were added by http://trac.webkit.org/changeset/175606 and http://trac.webkit.org/changeset/175605 , but weren't used ever. Let's remove them.
Ryosuke Niwa
Comment 3 2015-02-26 09:39:12 PST
Comment on attachment 247423 [details] Patch Oh, I think these are used by Apple internal tools.
Csaba Osztrogonác
Comment 4 2015-02-26 09:41:38 PST
It would be great to have a reference to it somewhere.
Matthew Hanson
Comment 5 2015-02-26 10:19:42 PST
I hear what you're saying, Csaba. But can't it also be useful in and of itself? E.g. for use in personal workflow automation scripts? The git.py module is supposed to be an interface to the Git tool, and cherrypick merging is something that a person with a merge-based workflow would use fairly often.
Csaba Osztrogonác
Comment 6 2015-02-26 10:29:12 PST
(In reply to comment #5) > I hear what you're saying, Csaba. But can't it also be useful in and of > itself? E.g. for use in personal workflow automation scripts? Of course it can be. But I thought git.py is only used by webkitpy scripts, that's why thought it is unused. > The git.py module is supposed to be an interface to the Git tool, and > cherrypick merging is something that a person with a merge-based workflow > would use fairly often. See. I could imagine a publicly available webkit-patch cherry-pick <svn-revision> command. I assume you use these functions for similar use-case.
Note You need to log in before you can comment on or make changes to this bug.