Bug 142022

Summary: DFG abstract heaps should respect difference between heap and stack
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-02-25 13:38:07 PST
We will soon be in a world where a "world clobbering" operation cannot write to our stack, but may be able to read from it. This means that we need to change the DFG abstract heap hierarchy to have a notion of Heap that subsumes all that World previously subsumed, and a new notion of Stack that is a subtype of World and a sibling of Heap.
Attachments
the patch (16.01 KB, patch)
2015-02-25 13:40 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-02-25 13:40:53 PST
Created attachment 247339 [details] the patch
Geoffrey Garen
Comment 2 2015-02-25 13:45:47 PST
Comment on attachment 247339 [details] the patch r=me
Filip Pizlo
Comment 3 2015-02-25 20:29:57 PST
Landed in http://trac.webkit.org/changeset/180656
Note You need to log in before you can comment on or make changes to this bug.