Bug 142021

Summary: Get rid of TestInvocation::pathOrURL
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 thorton: review+

Brady Eidson
Reported 2015-02-25 13:14:03 PST
Get rid of TestInvocation::pathOrURL When running tests using `run-webkit-tests`, the pathOrURL string is always an absolute path. But when running tests using `WebKitTestRunner <path to test>`, the pathOrURL string can be a relative path. If you are inside a "special" directory and invoke WebKitTestRunner directly on a test in that directory, then the pathOrURL string does NOT contain that directory name. Therefore, special behavior based on the directory name does not take place. The pathOrURL string never really needs to be exposed, so this is a pretty good cleanup.
Attachments
Patch v1 (11.13 KB, patch)
2015-02-25 13:19 PST, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-02-25 13:19:07 PST
Created attachment 247337 [details] Patch v1
Brady Eidson
Comment 2 2015-02-25 13:28:07 PST
http://trac.webkit.org/changeset/180636
Note You need to log in before you can comment on or make changes to this bug.