| Summary: | Web Inspector: Improve Regex/Error output in Object Tree and Previews | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 247319 [details]
[PATCH] Proposed Fix
RegExps look way better with this.
Created attachment 247320 [details]
[PATCH] Proposed Fix
Even better, this applies the same "titleElement" improvement to ObjectTree without preview.
This makes it so:
js> dir(null)
js> dir(100)
js> dir(true)
And friends show an Object Tree with a formatted value in the title, instead of black text.
Comment on attachment 247320 [details]
[PATCH] Proposed Fix
Nice!
Comment on attachment 247320 [details] [PATCH] Proposed Fix Clearing flags on attachment: 247320 Committed r180625: <http://trac.webkit.org/changeset/180625> All reviewed patches have been landed. Closing bug. |
* SUMMARY Improve Regex/Error output in Object Tree and Previews. - Regex objects: - show lots of properties in previews that are not particularly useful - show as black in previews, instead of orange - show as black in object tree, instead of orange, when expanded to show properties => the formatted value (orange) "/foo/g" would be nicer always when visible - Error objects: - show lots of properties in previews that are not particularly useful - should be expandable to show properties