Bug 142010

Summary: Web Inspector: Improve Regex/Error output in Object Tree and Previews
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-02-25 00:10:33 PST
* SUMMARY Improve Regex/Error output in Object Tree and Previews. - Regex objects: - show lots of properties in previews that are not particularly useful - show as black in previews, instead of orange - show as black in object tree, instead of orange, when expanded to show properties => the formatted value (orange) "/foo/g" would be nicer always when visible - Error objects: - show lots of properties in previews that are not particularly useful - should be expandable to show properties
Attachments
[PATCH] Proposed Fix (5.76 KB, patch)
2015-02-25 00:16 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (6.88 KB, patch)
2015-02-25 00:23 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-25 00:11:04 PST
<rdar://problem/19950119>
Joseph Pecoraro
Comment 2 2015-02-25 00:16:13 PST
Created attachment 247319 [details] [PATCH] Proposed Fix RegExps look way better with this.
Joseph Pecoraro
Comment 3 2015-02-25 00:23:31 PST
Created attachment 247320 [details] [PATCH] Proposed Fix Even better, this applies the same "titleElement" improvement to ObjectTree without preview. This makes it so: js> dir(null) js> dir(100) js> dir(true) And friends show an Object Tree with a formatted value in the title, instead of black text.
Timothy Hatcher
Comment 4 2015-02-25 06:26:26 PST
Comment on attachment 247320 [details] [PATCH] Proposed Fix Nice!
WebKit Commit Bot
Comment 5 2015-02-25 07:10:23 PST
Comment on attachment 247320 [details] [PATCH] Proposed Fix Clearing flags on attachment: 247320 Committed r180625: <http://trac.webkit.org/changeset/180625>
WebKit Commit Bot
Comment 6 2015-02-25 07:10:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.