| Summary: | Web Inspector: Improve PropertyPath display strings for getters / values | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 247315 [details]
[PATCH] Proposed Fix
Comment on attachment 247315 [details] [PATCH] Proposed Fix Clearing flags on attachment: 247315 Committed r180624: <http://trac.webkit.org/changeset/180624> All reviewed patches have been landed. Closing bug. |
* SUMMARY Improve PropertyPath display strings for getters / values. js> dir([{property: {get value() { return 10; }}}]) <- ▼ 0: Object ▼ property: Object ▼ value: (...) Hovering value here should say: obj[0].property.__lookupGetter__("value") Once invoking the getter. Hovering value should say: obj[0].property.value We should elide __proto__ when dealing with values. We could probably keep them for getters, but lets leave them in to guarentee the absolute path.