Bug 141986

Summary:

AX: Implement support for ARIA 1.1 'switch' role

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, cfleizach, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

142016

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Patch	none
Patch	none

Joanmarie Diggs

Reported 2015-02-24 14:54:03 PST

ARIA 1.1 has a new 'switch' role. We need to support it. http://rawgit.com/w3c/aria/master/aria/aria.html#switch

Attachments
Patch (26.44 KB, patch) 2015-02-24 15:01 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (594.14 KB, application/zip) 2015-02-24 15:47 PST, Build Bot	no flags	Details
Patch (26.44 KB, patch) 2015-02-24 15:55 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Patch (27.96 KB, patch) 2015-02-24 16:52 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-02-24 14:54:35 PST

<rdar://problem/19944239>

Joanmarie Diggs

Comment 2 2015-02-24 15:01:49 PST

Created attachment 247269 [details] Patch

Joanmarie Diggs

Comment 3 2015-02-24 15:03:14 PST

Not yet asking for review. Using EWS to verify the Mavericks result since I don't have a Mavericks system and the Switch subrole is new to OS X.

Build Bot

Comment 4 2015-02-24 15:47:09 PST

Comment on attachment 247269 [details] Patch Attachment 247269 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5822384426713088 New failing tests: accessibility/roles-exposed.html

Build Bot

Comment 5 2015-02-24 15:47:12 PST

Created attachment 247272 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Joanmarie Diggs

Comment 6 2015-02-24 15:55:31 PST

Created attachment 247274 [details] Patch

Joanmarie Diggs

Comment 7 2015-02-24 16:24:42 PST

Chris: Could you please review this when you have chance? Thanks!

chris fleizach

Comment 8 2015-02-24 16:28:49 PST

Comment on attachment 247274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247274&action=review > Source/WebCore/ChangeLog:18 > + * accessibility/AccessibilityNodeObject.cpp: For iOS, can you add SwitchRole to the list in determineIsAccessibilityElement accessibilityCanFuzzyHitTest accessibilityTraits - > under CheckBoxRole > Source/WebCore/accessibility/AccessibilityObject.h:503 > + virtual bool isSwitch() const { return roleValue() == SwitchRole; } this probably doesn't need to be virtual

Joanmarie Diggs

Comment 9 2015-02-24 16:52:11 PST

Created attachment 247279 [details] Patch

chris fleizach

Comment 10 2015-02-24 16:53:39 PST

Comment on attachment 247279 [details] Patch looks good. thanks

WebKit Commit Bot

Comment 11 2015-02-24 17:44:00 PST

Comment on attachment 247279 [details] Patch Clearing flags on attachment: 247279 Committed r180600: <http://trac.webkit.org/changeset/180600>

WebKit Commit Bot

Comment 12 2015-02-24 17:44:06 PST

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 13 2015-02-25 09:15:33 PST

This caused several Windows layout test failures. Can someone please review and resolve this? Otherwise, I will roll it out.

Brent Fulgham

Comment 14 2015-02-25 09:17:12 PST

We need Windows EWS to run tests so this doesn't happen.

Note You need to log in before you can comment on or make changes to this bug.