Bug 141985

Summary:

Use an enum for scrollbar style

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Description Simon Fraser (smfr) 2015-02-24 14:52:58 PST

Use an enum for scrollbar style

Comment 1 Simon Fraser (smfr) 2015-02-24 14:54:19 PST

Created attachment 247268 [details]
Patch

Comment 2 Beth Dakin 2015-02-24 15:01:12 PST

Comment on attachment 247268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247268&action=review

> Source/WebCore/platform/ScrollTypes.h:159
> +        Normal,

I object!!! I think that overlay is definitely the new normal. Legacy would be more appropriate. Alternatively, maybe something like Physical? Permanent? SpaceOccupying? AlwaysVisible? None of these are very good, but I definitely object to Normal.

Comment 3 Simon Fraser (smfr) 2015-02-24 20:08:01 PST

https://trac.webkit.org/r180607