| Summary: | [Mac] [iOS] Parsing support for -apple-trailing-word | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, dino, hyatt, jonlee, kling, koivisto, rniwa, sam, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Bug Depends on: | 141998, 142000 | ||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2015-02-23 17:29:34 PST
Created attachment 247174 [details]
Patch
Created attachment 247185 [details]
Patch
Created attachment 247186 [details]
Patch
Created attachment 247188 [details]
Patch
Comment on attachment 247188 [details] Patch Attachment 247188 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5599821268254720 New failing tests: fast/forms/targeted-frame-submission.html http/tests/misc/acid3.html fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html tables/mozilla_expected_failures/bugs/bug2479-5.html Created attachment 247197 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 247188 [details] Patch Attachment 247188 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4647036561391616 New failing tests: fast/forms/targeted-frame-submission.html fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html Created attachment 247203 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 247248 [details]
Patch
Comment on attachment 247248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247248&action=review This looks good, though I'd prefer we name the flag CSS_TRAILING_WORD to make it a bit more clear what this is about. r=me > Source/WebCore/css/CSSPrimitiveValueMappings.h:5259 > + } Maybe a default case here with ASSERT_NOT_REACHED to match operator TrailingWord()? > Source/WebCore/rendering/style/RenderStyle.h:1653 > + void setTrailingWord(TrailingWord v) { SET_VAR(rareInheritedData, trailingWord, static_cast<int>(v)); } Shouldn't the static_cast be to <unsigned> here rather than <int>, given that StyleRareInheritedData::trailingWord is unsigned? Comment on attachment 247248 [details] Patch Attachment 247248 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6589789755146240 New failing tests: fast/forms/targeted-frame-submission.html tables/mozilla/bugs/bug139524-2.html Created attachment 247251 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 247248 [details] Patch Attachment 247248 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5020605199941632 New failing tests: editing/selection/designmode-no-caret.html fast/forms/targeted-frame-submission.html Created attachment 247252 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Committed r180599: <http://trac.webkit.org/changeset/180599> Re-opened since this is blocked by bug 141998 This causes flakiness. Created attachment 247332 [details]
Test list for failures
Comment on attachment 247248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247248&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:169 > + if (style.trailingWord() != TrailingWord::Auto) > + return false; This seems to have caused the flakiness.... Created attachment 247340 [details]
Patch
I wasn't initializing the new state in RenderStyle upon creation. Comment on attachment 247340 [details]
Patch
I'll commit this tomorrow.
Committed r180689: <http://trac.webkit.org/changeset/180689> |