Summary: | Weak symbol warning when linking TestWebKitAPI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
Component: | Tools / Tests | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, dbates, ddkilzer | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=224812 | ||||||||
Bug Depends on: | 142320 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Brian Burg
2015-02-23 10:20:21 PST
I'm pretty sure that I did indeed cause this when I switched away from WebCore.exp.in. This doesn't seem to be breaking any builds, but this should be fixed along with the final cleaning up from that switch. Created attachment 247907 [details]
Patch
Comment on attachment 247907 [details]
Patch
r=me
Comment on attachment 247907 [details] Patch Clearing flags on attachment: 247907 Committed r181054: <http://trac.webkit.org/changeset/181054> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 142320 Created attachment 247978 [details]
Patch
The previous patch broke some API tests even though it compiled correctly. I'm honestly not sure why. This patch compiles correctly and doesn't break run-api-tests. Comment on attachment 247978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247978&action=review r=me > Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:27 > +UNEXPORTED_SYMBOL_LDFLAGS = -Wl,-unexported_symbol -Wl,__ZN7testing4Test16TearDownTestCaseEv -Wl,-unexported_symbol -Wl,__ZN7testing4Test13SetUpTestCaseEv If we have to add more of these symbols in the future, we should put them in an *.unexp file. This is slightly ugly to maintain. Comment on attachment 247978 [details] Patch Clearing flags on attachment: 247978 Committed r181113: <http://trac.webkit.org/changeset/181113> All reviewed patches have been landed. Closing bug. |