Bug 141910

Summary:

Occasional crash in MediaPlayer::setPrivateBrowsingMode

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=155721

Attachments:

Description	Flags
Proposed patch	none

Description Eric Carlson 2015-02-23 09:16:08 PST

The iOS bots occasionally crash in MediaPlayer::setPrivateBrowsingMode:

WebCore::MediaPlayer::setPrivateBrowsingMode(bool) + 4
WebCore::HTMLMediaElement::loadResource(WebCore::URL const&, WebCore::ContentType&, WTF::String const&) + 1160
WebCore::HTMLMediaElement::selectMediaResource() + 802
WebCore::HTMLMediaElement::loadTimerFired() + 77

Comment 1 Eric Carlson 2015-02-23 09:19:22 PST

Created attachment 247123 [details]
Proposed patch

Comment 2 Jer Noble 2015-02-23 11:13:16 PST

Comment on attachment 247123 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247123&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:4743
> +    clearMediaPlayer(-1);

😱

Could we add an entry to DelayedActionType called "AllActions" or something?

Comment 3 Eric Carlson 2015-02-23 11:28:36 PST

Committed r180510: https://trac.webkit.org/r180510