Bug 141876

Summary: Web Inspector: Make Console UI icons / lines slightly larger
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-02-21 18:35:40 PST 
* SUMMARY
Make Console UI icons / lines slightly larger.

This is in preparation for a new ObjectTree design that contains 16x16 icons. So bump up the size of the existing Console icons / lines which are currently much smaller (10x10). This brings them up to 12x12.
Comment 1 Joseph Pecoraro 2015-02-21 18:41:29 PST 
Created attachment 247073 [details]
[PATCH] Proposed Fix

Overall I think this is shippable.

I was seeing an issue where certain error lines were 22px tall instead of 21. I was unable to track down that particular issue. Lets address it separately though.
Comment 2 WebKit Commit Bot 2015-02-21 18:43:07 PST 
Attachment 247073 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/Views/LogContentView.css:445:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2015-02-21 19:04:55 PST 
Created attachment 247075 [details]
[PATCH] Proposed Fix

Fixed style issue.
Comment 4 WebKit Commit Bot 2015-02-22 08:43:48 PST 
Comment on attachment 247075 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 247075

Committed r180484: <http://trac.webkit.org/changeset/180484>
Comment 5 WebKit Commit Bot 2015-02-22 08:43:52 PST 
All reviewed patches have been landed.  Closing bug.