Bug 141855

Summary:

Scrollbars and ScrollAnimators must always have a ScrollableArea

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Layout and Rendering

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bfulgham, koivisto, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

140633

Attachments:

Description	Flags
Patch	none
Patch	none
Patch v3 (Fixes for Windows and other ports)	none
Patch v4 (iOS fixes)	none
Patch v5 (Efl fix)	none
Patch	none
Patch v7 (Gtk fix)	simon.fraser: review+

Description Brent Fulgham 2015-02-20 14:21:58 PST

It doesn't make sense for a ScrollAnimator to exist without a ScrollableArea. So rather than holding a pointer to the ScrollableArea it is responsible for, have it use a reference.

Comment 1 Brent Fulgham 2015-02-20 14:38:47 PST

Likewise, a Scrollbar should always be associated with a ScrollArea.

Comment 2 Brent Fulgham 2015-02-20 16:36:46 PST

Created attachment 247011 [details]
Patch

Comment 3 Brent Fulgham 2015-02-20 16:57:16 PST

Created attachment 247013 [details]
Patch

Comment 4 Brent Fulgham 2015-02-20 17:28:49 PST

Created attachment 247018 [details]
Patch v3 (Fixes for Windows and other ports)

Comment 5 Brent Fulgham 2015-02-20 17:35:37 PST

Created attachment 247019 [details]
Patch v4 (iOS fixes)

Comment 6 Brent Fulgham 2015-02-20 17:37:57 PST

Created attachment 247021 [details]
Patch v5 (Efl fix)

Comment 7 Radar WebKit Bug Importer 2015-02-20 17:39:15 PST

<rdar://problem/19912140>

Comment 8 Brent Fulgham 2015-02-20 17:50:08 PST

Created attachment 247023 [details]
Patch

Comment 9 Brent Fulgham 2015-02-20 18:05:20 PST

Created attachment 247028 [details]
Patch v7 (Gtk fix)

Comment 10 Brent Fulgham 2015-02-20 19:34:20 PST

Committed r180474: <http://trac.webkit.org/changeset/180474>

Comment 11 Brent Fulgham 2015-02-20 19:36:04 PST

I think I fixed the Gtk build when I landed, but I will watch the bots to make sure.

Comment 12 Brent Fulgham 2015-02-20 19:45:26 PST

(In reply to comment #11)
> I think I fixed the Gtk build when I landed, but I will watch the bots to
> make sure.

Bah! Of course I failed.

Gtk build fix in r180475. <http://trac.webkit.org/changeset/180475>