Summary: | [GTK] Layout Test media/video-controls-no-scripting.html is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991> | ||||
Component: | Tools / Tests | Assignee: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, bugs-noreply, chavarria1991, clopez, commit-queue, Ms2ger, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=152797 | ||||||
Attachments: |
|
Description
Marcos Chavarría Teijeiro (irc: chavaone)
2015-02-20 03:17:03 PST
It's probably fine to update the results for now, however this may be a sign of a bug in console that line number generation is flaky on this test. The test is failing again after r184329 (). The new diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-actual.txt @@ -1,5 +1,6 @@ CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. +CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. Tests that the built-in controls are always enabled when JavaScript is disabled. This test is now timing out because of bug 152797 Created attachment 318488 [details]
Patch
Comment on attachment 318488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318488&action=review > LayoutTests/ChangeLog:8 > + The output appears to be consistent based on local testing. You can see its still failing on the bot: media/video-controls-no-scripting-diff.txt $ curl -s https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/2689/steps/layout-test/logs/stdio/text|grep media/video-controls-no-scripting 03:22:36.244 11162 "ruby -I /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-diff.txt" took 0.16s 03:22:36.245 11162 worker/9 media/video-controls-no-scripting.html failed: And you can find the diff here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r220912%20(2689)/media/video-controls-no-scripting-pretty-diff.html Comment on attachment 318488 [details]
Patch
Ok... missed the rebaseline. Sorry
/me goes for more coffee
Comment on attachment 318488 [details] Patch Clearing flags on attachment: 318488 Committed r220915: <http://trac.webkit.org/changeset/220915> All reviewed patches have been landed. Closing bug. |