Bug 141835

Summary: [GTK] Layout Test media/video-controls-no-scripting.html is failing
Product: WebKit Reporter: Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>
Component: Tools / TestsAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bugs-noreply, chavarria1991, clopez, commit-queue, Ms2ger, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=152797
Attachments:
Description Flags
Patch none

Marcos Chavarría Teijeiro (irc: chavaone)
Reported 2015-02-20 03:17:03 PST
The media/video-controls-no-scripting.html layout test is failing after rr178648. Probably we need to rebaseline the test here. Missing line number: --- /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-expected.txt +++ /home/ch01/wk-tools/layout-test-results/media/video-controls-no-scripting-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 10: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. +CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. Tests that the built-in controls are always enabled when JavaScript is disabled.
Attachments
Patch (2.72 KB, patch)
2017-08-18 03:20 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Alexey Proskuryakov
Comment 1 2015-02-20 09:46:05 PST
It's probably fine to update the results for now, however this may be a sign of a bug in console that line number generation is flaky on this test.
Marcos Chavarría Teijeiro (irc: chavaone)
Comment 2 2015-05-15 02:50:09 PDT
The test is failing again after r184329 (). The new diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-actual.txt @@ -1,5 +1,6 @@ CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. +CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set. Tests that the built-in controls are always enabled when JavaScript is disabled.
Carlos Alberto Lopez Perez
Comment 3 2016-01-06 12:27:38 PST
This test is now timing out because of bug 152797
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2017-08-18 03:20:21 PDT
Carlos Alberto Lopez Perez
Comment 5 2017-08-18 06:11:10 PDT
Comment on attachment 318488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318488&action=review > LayoutTests/ChangeLog:8 > + The output appears to be consistent based on local testing. You can see its still failing on the bot: media/video-controls-no-scripting-diff.txt $ curl -s https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/2689/steps/layout-test/logs/stdio/text|grep media/video-controls-no-scripting 03:22:36.244 11162 "ruby -I /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-no-scripting-diff.txt" took 0.16s 03:22:36.245 11162 worker/9 media/video-controls-no-scripting.html failed: And you can find the diff here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r220912%20(2689)/media/video-controls-no-scripting-pretty-diff.html
Carlos Alberto Lopez Perez
Comment 6 2017-08-18 06:12:28 PDT
Comment on attachment 318488 [details] Patch Ok... missed the rebaseline. Sorry /me goes for more coffee
WebKit Commit Bot
Comment 7 2017-08-18 06:42:01 PDT
Comment on attachment 318488 [details] Patch Clearing flags on attachment: 318488 Committed r220915: <http://trac.webkit.org/changeset/220915>
WebKit Commit Bot
Comment 8 2017-08-18 06:42:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-18 06:43:19 PDT
Note You need to log in before you can comment on or make changes to this bug.