| Summary: | [WebEditingTester] Factor out list of editing operations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, enrica, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-02-20 02:01:24 PST
Created attachment 246947 [details]
Patch
Attachment 246947 [details] did not pass style-queue:
ERROR: Tools/WebEditingTester/EditingOperations.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246947&action=review > Tools/WebEditingTester/EditingOperations.m:35 > + static NSArray *operationNames; > + static dispatch_once_t onceToken; > + dispatch_once(&onceToken, ^{ > + operationNames = @[ I don't think you need the dispatch_once here. I think you can just return the array literal. |